lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 059/141] regulator: as3722: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    by explicitly adding a fallthrough pseudo-keyword instead of letting the
    code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/regulator/as3722-regulator.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/drivers/regulator/as3722-regulator.c b/drivers/regulator/as3722-regulator.c
    index 33ca197860b3..7bebf9ce6271 100644
    --- a/drivers/regulator/as3722-regulator.c
    +++ b/drivers/regulator/as3722-regulator.c
    @@ -455,7 +455,8 @@ static int as3722_sd_set_mode(struct regulator_dev *rdev,
    switch (mode) {
    case REGULATOR_MODE_FAST:
    val = as3722_reg_lookup[id].mode_mask;
    - case REGULATOR_MODE_NORMAL: /* fall down */
    + fallthrough;
    + case REGULATOR_MODE_NORMAL:
    break;
    default:
    return -EINVAL;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:35    [W:4.255 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site