lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 005/141] drm/radeon: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple fallthrough pseudo-keyword macros,
    as replacement for /* fall through */ comments.

    Notice that Clang doesn't recognize /* fall through */ comments as
    implicit fall-through markings.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/gpu/drm/radeon/ci_dpm.c | 2 +-
    drivers/gpu/drm/radeon/r300.c | 1 +
    drivers/gpu/drm/radeon/si_dpm.c | 2 +-
    3 files changed, 3 insertions(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/radeon/ci_dpm.c b/drivers/gpu/drm/radeon/ci_dpm.c
    index 886e9959496f..3d0a2e81b2de 100644
    --- a/drivers/gpu/drm/radeon/ci_dpm.c
    +++ b/drivers/gpu/drm/radeon/ci_dpm.c
    @@ -4860,8 +4860,8 @@ static void ci_request_link_speed_change_before_state_change(struct radeon_devic
    case RADEON_PCIE_GEN2:
    if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0)
    break;
    + fallthrough;
    #endif
    - /* fall through */
    default:
    pi->force_pcie_gen = ci_get_current_pcie_speed(rdev);
    break;
    diff --git a/drivers/gpu/drm/radeon/r300.c b/drivers/gpu/drm/radeon/r300.c
    index 73f67bf222e1..213dc49b6322 100644
    --- a/drivers/gpu/drm/radeon/r300.c
    +++ b/drivers/gpu/drm/radeon/r300.c
    @@ -1162,6 +1162,7 @@ static int r300_packet0_check(struct radeon_cs_parser *p,
    /* valid register only on RV530 */
    if (p->rdev->family == CHIP_RV530)
    break;
    + fallthrough;
    /* fallthrough do not move */
    default:
    goto fail;
    diff --git a/drivers/gpu/drm/radeon/si_dpm.c b/drivers/gpu/drm/radeon/si_dpm.c
    index d1c73e9db889..d19c08e0ad5a 100644
    --- a/drivers/gpu/drm/radeon/si_dpm.c
    +++ b/drivers/gpu/drm/radeon/si_dpm.c
    @@ -5748,8 +5748,8 @@ static void si_request_link_speed_change_before_state_change(struct radeon_devic
    case RADEON_PCIE_GEN2:
    if (radeon_acpi_pcie_performance_request(rdev, PCIE_PERF_REQ_PECI_GEN2, false) == 0)
    break;
    + fallthrough;
    #endif
    - /* fall through */
    default:
    si_pi->force_pcie_gen = si_get_current_pcie_speed(rdev);
    break;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:27    [W:4.270 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site