lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 017/141] nfs: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly add multiple break/goto/return/fallthrough
    statements instead of just letting the code fall through to the next
    case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    fs/nfs/nfs3acl.c | 1 +
    fs/nfs/nfs4client.c | 1 +
    fs/nfs/nfs4proc.c | 2 ++
    fs/nfs/nfs4state.c | 1 +
    fs/nfs/pnfs.c | 2 ++
    5 files changed, 7 insertions(+)

    diff --git a/fs/nfs/nfs3acl.c b/fs/nfs/nfs3acl.c
    index c6c863382f37..68e206cf4c4e 100644
    --- a/fs/nfs/nfs3acl.c
    +++ b/fs/nfs/nfs3acl.c
    @@ -111,6 +111,7 @@ struct posix_acl *nfs3_get_acl(struct inode *inode, int type)
    fallthrough;
    case -ENOTSUPP:
    status = -EOPNOTSUPP;
    + goto getout;
    default:
    goto getout;
    }
    diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c
    index be7915c861ce..4bdd256b725a 100644
    --- a/fs/nfs/nfs4client.c
    +++ b/fs/nfs/nfs4client.c
    @@ -609,6 +609,7 @@ int nfs40_walk_client_list(struct nfs_client *new,
    * changed. Schedule recovery!
    */
    nfs4_schedule_path_down_recovery(pos);
    + goto out;
    default:
    goto out;
    }
    diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
    index 9e0ca9b2b210..98c9f3197647 100644
    --- a/fs/nfs/nfs4proc.c
    +++ b/fs/nfs/nfs4proc.c
    @@ -2229,6 +2229,7 @@ static int nfs4_handle_delegation_recall_error(struct nfs_server *server, struct
    default:
    printk(KERN_ERR "NFS: %s: unhandled error "
    "%d.\n", __func__, err);
    + fallthrough;
    case 0:
    case -ENOENT:
    case -EAGAIN:
    @@ -9698,6 +9699,7 @@ nfs4_layoutcommit_done(struct rpc_task *task, void *calldata)
    case -NFS4ERR_BADLAYOUT: /* no layout */
    case -NFS4ERR_GRACE: /* loca_recalim always false */
    task->tk_status = 0;
    + break;
    case 0:
    break;
    default:
    diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
    index 4bf10792cb5b..3a51351bdc6a 100644
    --- a/fs/nfs/nfs4state.c
    +++ b/fs/nfs/nfs4state.c
    @@ -1125,6 +1125,7 @@ static void nfs_increment_seqid(int status, struct nfs_seqid *seqid)
    " sequence-id error on an"
    " unconfirmed sequence %p!\n",
    seqid->sequence);
    + return;
    case -NFS4ERR_STALE_CLIENTID:
    case -NFS4ERR_STALE_STATEID:
    case -NFS4ERR_BAD_STATEID:
    diff --git a/fs/nfs/pnfs.c b/fs/nfs/pnfs.c
    index 0e50b9d45c32..7f71f4f8347f 100644
    --- a/fs/nfs/pnfs.c
    +++ b/fs/nfs/pnfs.c
    @@ -2824,6 +2824,7 @@ pnfs_do_write(struct nfs_pageio_descriptor *desc,
    switch (trypnfs) {
    case PNFS_NOT_ATTEMPTED:
    pnfs_write_through_mds(desc, hdr);
    + break;
    case PNFS_ATTEMPTED:
    break;
    case PNFS_TRY_AGAIN:
    @@ -2968,6 +2969,7 @@ pnfs_do_read(struct nfs_pageio_descriptor *desc, struct nfs_pgio_header *hdr)
    switch (trypnfs) {
    case PNFS_NOT_ATTEMPTED:
    pnfs_read_through_mds(desc, hdr);
    + break;
    case PNFS_ATTEMPTED:
    break;
    case PNFS_TRY_AGAIN:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:4.172 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site