lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 012/141] ixgbe: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple break statements instead of just
    letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 2 ++
    drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 1 +
    drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 1 +
    drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c | 1 +
    4 files changed, 5 insertions(+)

    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
    index 8d3798a32f0e..cdfff510a27b 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
    @@ -1542,6 +1542,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,
    switch (input_mask->formatted.vm_pool & 0x7F) {
    case 0x0:
    fdirm |= IXGBE_FDIRM_POOL;
    + break;
    case 0x7F:
    break;
    default:
    @@ -1557,6 +1558,7 @@ s32 ixgbe_fdir_set_input_mask_82599(struct ixgbe_hw *hw,
    hw_dbg(hw, " Error on src/dst port mask\n");
    return IXGBE_ERR_CONFIG;
    }
    + break;
    case IXGBE_ATR_L4TYPE_MASK:
    break;
    default:
    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
    index 62ddb452f862..8d5a01be1d99 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
    @@ -93,6 +93,7 @@ bool ixgbe_device_supports_autoneg_fc(struct ixgbe_hw *hw)
    default:
    break;
    }
    + break;
    default:
    break;
    }
    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
    index df389a11d3af..0218f6c9b925 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
    @@ -132,6 +132,7 @@ static void ixgbe_get_first_reg_idx(struct ixgbe_adapter *adapter, u8 tc,
    else
    *tx = (tc + 4) << 4; /* 96, 112 */
    }
    + break;
    default:
    break;
    }
    diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
    index 22a874eee2e8..23ddfd79fc8b 100644
    --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
    +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ptp.c
    @@ -999,6 +999,7 @@ static int ixgbe_ptp_set_timestamp_mode(struct ixgbe_adapter *adapter,
    switch (config->tx_type) {
    case HWTSTAMP_TX_OFF:
    tsync_tx_ctl = 0;
    + break;
    case HWTSTAMP_TX_ON:
    break;
    default:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:4.178 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site