lkml.org 
[lkml]   [2020]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 060/141] habanalabs: Fix fall-through warnings for Clang
    On Fri, Nov 20, 2020 at 8:33 PM Gustavo A. R. Silva
    <gustavoars@kernel.org> wrote:
    >
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a fallthrough pseudo-keyword instead of letting the
    > code fall through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/misc/habanalabs/gaudi/gaudi.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c
    > index 2519a34e25b7..eab4c0dc65c5 100644
    > --- a/drivers/misc/habanalabs/gaudi/gaudi.c
    > +++ b/drivers/misc/habanalabs/gaudi/gaudi.c
    > @@ -5436,6 +5436,7 @@ static void gaudi_handle_ecc_event(struct hl_device *hdev, u16 event_type,
    > params.num_memories = 33;
    > params.derr = true;
    > params.disable_clock_gating = true;
    > + fallthrough;
    > default:
    > return;
    > }
    > --
    > 2.27.0
    >
    Hi Gustavo,
    So this is actually an error in the code, there shouldn't be a
    fallthrough there.
    So NAK for this patch, I'll have to send a fix for that.
    Thanks for catching this :)

    Oded

    \
     
     \ /
      Last update: 2020-11-21 13:36    [W:2.056 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site