lkml.org 
[lkml]   [2020]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 131/141] tpm: Fix fall-through warnings for Clang
    On Fri, Nov 20, 2020 at 12:40:14PM -0600, Gustavo A. R. Silva wrote:
    > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
    > by explicitly adding a break statement instead of letting the code fall
    > through to the next case.
    >
    > Link: https://github.com/KSPP/linux/issues/115
    > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    > ---
    > drivers/char/tpm/eventlog/tpm1.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/char/tpm/eventlog/tpm1.c b/drivers/char/tpm/eventlog/tpm1.c
    > index 2c96977ad080..8aa9057601d6 100644
    > --- a/drivers/char/tpm/eventlog/tpm1.c
    > +++ b/drivers/char/tpm/eventlog/tpm1.c
    > @@ -210,6 +210,7 @@ static int get_event_name(char *dest, struct tcpa_event *event,
    > default:
    > break;
    > }
    > + break;
    > default:
    > break;
    > }
    > --
    > 2.27.0
    >
    >

    Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@iki.fi>

    Who is picking these patches?

    /Jarkko

    \
     
     \ /
      Last update: 2020-11-24 00:09    [W:4.028 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site