lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 006/141] gfs2: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding multiple goto statements instead of just
    letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    fs/gfs2/inode.c | 2 ++
    fs/gfs2/recovery.c | 1 +
    2 files changed, 3 insertions(+)

    diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
    index 077ccb1b3ccc..9a85214c2505 100644
    --- a/fs/gfs2/inode.c
    +++ b/fs/gfs2/inode.c
    @@ -960,6 +960,7 @@ static int gfs2_link(struct dentry *old_dentry, struct inode *dir,
    break;
    case 0:
    error = -EEXIST;
    + goto out_gunlock;
    default:
    goto out_gunlock;
    }
    @@ -1500,6 +1501,7 @@ static int gfs2_rename(struct inode *odir, struct dentry *odentry,
    break;
    case 0:
    error = -EEXIST;
    + goto out_gunlock;
    default:
    goto out_gunlock;
    }
    diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
    index c26c68ebd29d..5b2a01d9c463 100644
    --- a/fs/gfs2/recovery.c
    +++ b/fs/gfs2/recovery.c
    @@ -437,6 +437,7 @@ void gfs2_recover_func(struct work_struct *work)
    case GLR_TRYFAILED:
    fs_info(sdp, "jid=%u: Busy\n", jd->jd_jid);
    error = 0;
    + goto fail;

    default:
    goto fail;
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:27    [W:4.261 / U:0.220 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site