lkml.org 
[lkml]   [2020]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 019/141] qlcnic: Fix fall-through warnings for Clang
    In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
    warnings by explicitly adding a break and a goto statements instead of
    just letting the code fall through to the next case.

    Link: https://github.com/KSPP/linux/issues/115
    Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
    ---
    drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c | 1 +
    drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
    2 files changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
    index bdf15d2a6431..af4c516a9e7c 100644
    --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
    +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c
    @@ -1390,6 +1390,7 @@ static int qlcnic_process_rcv_ring(struct qlcnic_host_sds_ring *sds_ring, int ma
    break;
    case QLCNIC_RESPONSE_DESC:
    qlcnic_handle_fw_message(desc_cnt, consumer, sds_ring);
    + goto skip;
    default:
    goto skip;
    }
    diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
    index 5a7e240fd469..3abbd22e2ed3 100644
    --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
    +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
    @@ -3456,6 +3456,7 @@ qlcnic_fwinit_work(struct work_struct *work)
    adapter->fw_wait_cnt = 0;
    return;
    }
    + break;
    case QLCNIC_DEV_FAILED:
    break;
    default:
    --
    2.27.0
    \
     
     \ /
      Last update: 2020-11-20 19:39    [W:2.159 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site