| From | Thomas Gleixner <> | Subject | [patch 01/39] PCI/MSI: Check for MSI enabled in __pci_msix_enable() | Date | Fri, 11 Nov 2022 14:54:15 +0100 (CET) |
| |
PCI/MSI and PCI/MSI-X are mutually exclusive, but the MSI-X enable code lacks a check for already enabled MSI.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de> --- drivers/pci/msi/msi.c | 5 +++++ 1 file changed, 5 insertions(+)
--- a/drivers/pci/msi/msi.c +++ b/drivers/pci/msi/msi.c @@ -935,6 +935,11 @@ static int __pci_enable_msix_range(struc if (maxvec < minvec) return -ERANGE; + if (dev->msi_enabled) { + pci_info(dev, "can't enable MSI-X (MSI already enabled)\n"); + return -EINVAL; + } + if (WARN_ON_ONCE(dev->msix_enabled)) return -EINVAL;
|