lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch 03/39] iommu/amd: Remove bogus check for multi MSI-X
    Date
    On Wed, Nov 16 2022 at 08:02, Ashok Raj wrote:
    > On Fri, Nov 11, 2022 at 02:54:19PM +0100, Thomas Gleixner wrote:
    >> PCI/Multi-MSI is MSI specific and not supported for MSI-X
    >>
    >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    >> ---
    >> drivers/iommu/amd/iommu.c | 3 +--
    >> 1 file changed, 1 insertion(+), 2 deletions(-)
    >>
    >> --- a/drivers/iommu/amd/iommu.c
    >> +++ b/drivers/iommu/amd/iommu.c
    >> @@ -3294,8 +3294,7 @@ static int irq_remapping_alloc(struct ir
    >>
    >> if (!info)
    >> return -EINVAL;
    >> - if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI &&
    >> - info->type != X86_IRQ_ALLOC_TYPE_PCI_MSIX)
    >> + if (nr_irqs > 1 && info->type != X86_IRQ_ALLOC_TYPE_PCI_MSI)
    >> return -EINVAL;
    >>
    >> /*
    >>
    >
    > nit:
    >
    > maybe better to merge patch2/3 since both seem related?

    What's better about it? It's two different drivers.

    \
     
     \ /
      Last update: 2022-11-16 18:04    [W:3.885 / U:0.316 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site