lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 30/39] PCI/MSI: Move pci_msi_restore_state() to api.c
    On Fri, Nov 11, 2022 at 02:55:03PM +0100, Thomas Gleixner wrote:
    > From: Ahmed S. Darwish <darwi@linutronix.de>
    >
    > To distangle the maze in msi.c, all exported device-driver MSI APIs are
    > now to be grouped in one file, api.c.
    >
    > Move pci_msi_enabled() and add kernel-doc for the function.
    >
    > Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    >
    > diff --git a/drivers/pci/msi/api.c b/drivers/pci/msi/api.c
    > index ee9ed5ccd94d..8d1cf6db9bd7 100644
    > --- a/drivers/pci/msi/api.c
    > +++ b/drivers/pci/msi/api.c
    > @@ -308,6 +308,21 @@ void pci_free_irq_vectors(struct pci_dev *dev)
    > }
    > EXPORT_SYMBOL(pci_free_irq_vectors);
    >
    > +/**
    > + * pci_restore_msi_state() - Restore cached MSI(-X) state on device
    > + * @dev: the PCI device to operate on
    > + *
    > + * Write the Linux-cached MSI(-X) state back on device. This is
    > + * typically useful upon system resume, or after an error-recovery PCI
    > + * adapter reset.
    > + */
    > +void pci_restore_msi_state(struct pci_dev *dev)
    > +{
    > + __pci_restore_msi_state(dev);
    > + __pci_restore_msix_state(dev);
    > +}
    > +EXPORT_SYMBOL_GPL(pci_restore_msi_state);

    This leaves behind two functions that are only called from here.

    I think they should be moved into this file as well.

    Or perhaps more broadly, it would make sense if the functions
    were split up into 'for irq chip implementors' 'for drivers' and
    'shared utilities'.

    There are several other examples, like
    __pci_enable_msix_range()/__pci_enable_msi_range() that are only used
    by api.c and could reasonably move as well, plus their tree of
    single-use support functions.

    And if you think about it that way - things have ended up so that
    api.c is really all about vector allocation (as that is the only thing
    the drivers actually do) so it would be tempting to call it
    allocator.c and consolidate everything in that topic.

    Jason

    \
     
     \ /
      Last update: 2022-11-16 18:43    [W:14.423 / U:0.324 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site