lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [patch 12/39] genirq/msi: Add bus token to struct msi_domain_info
Date
On Wed, Nov 16 2022 at 13:49, Jason Gunthorpe wrote:

> On Fri, Nov 11, 2022 at 02:54:33PM +0100, Thomas Gleixner wrote:
>> From: Ahmed S. Darwish <darwi@linutronix.de>
>>
>> Add a bus token member to struct msi_domain_info and let
>> msi_create_irq_domain() set the bus token.
>>
>> That allows to remove the bus token updates at the call sites.
>>
>> Suggested-by: Thomas Gleixner <tglx@linutronix.de>
>> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>> ---
>> include/linux/msi.h | 19 +++++++++++--------
>> kernel/irq/msi.c | 7 +++++--
>> 2 files changed, 16 insertions(+), 10 deletions(-)
>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>
>> struct msi_domain_info {
>> - u32 flags;
>> - struct msi_domain_ops *ops;
>> - struct irq_chip *chip;
>> - void *chip_data;
>> - irq_flow_handler_t handler;
>> - void *handler_data;
>> - const char *handler_name;
>> - void *data;
>> + u32 flags;
>> + enum irq_domain_bus_token bus_token;
>> + struct msi_domain_ops *ops;
>> + struct irq_chip *chip;
>> + void *chip_data;
>> + irq_flow_handler_t handler;
>> + void *handler_data;
>> + const char *handler_name;
>> + void *data;
>> };
>
> This is why I've been frowning on horizontal alignment :(

Yes, it's annoying when you have to adjust it, but it's fundamentaly
simpler to parse than the clogged together word salad.

\
 
 \ /
  Last update: 2022-11-16 23:51    [W:0.156 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site