lkml.org 
[lkml]   [2022]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 13/39] PCI/MSI: Use msi_domain_info::bus_token
    On Fri, Nov 11, 2022 at 02:54:35PM +0100, Thomas Gleixner wrote:
    > From: Ahmed S. Darwish <darwi@linutronix.de>
    >
    > Set the bus token in the msi_domain_info structure and let the core code
    > handle the update.
    >
    > Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de>
    > Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    > ---
    > drivers/pci/msi/irqdomain.c | 11 +++--------
    > 1 file changed, 3 insertions(+), 8 deletions(-)
    >
    > --- a/drivers/pci/msi/irqdomain.c
    > +++ b/drivers/pci/msi/irqdomain.c
    > @@ -162,8 +162,6 @@ struct irq_domain *pci_msi_create_irq_do
    > struct msi_domain_info *info,
    > struct irq_domain *parent)
    > {
    > - struct irq_domain *domain;
    > -
    > if (WARN_ON(info->flags & MSI_FLAG_LEVEL_CAPABLE))
    > info->flags &= ~MSI_FLAG_LEVEL_CAPABLE;
    >
    > @@ -178,13 +176,10 @@ struct irq_domain *pci_msi_create_irq_do
    >
    > /* PCI-MSI is oneshot-safe */
    > info->chip->flags |= IRQCHIP_ONESHOT_SAFE;
    > + /* Let the core update the bus token */
    > + info->bus_token = DOMAIN_BUS_PCI_MSI;

    comment seems a bit obvious

    Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

    Should the callers be updated to set this in their "struct
    msi_domain_info" ?

    Jason

    \
     
     \ /
      Last update: 2022-11-16 18:52    [W:2.394 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site