Messages in this thread | | | Date | Wed, 16 Nov 2022 13:57:25 -0400 | From | Jason Gunthorpe <> | Subject | Re: [patch 33/39] PCI/MSI: Sanitize MSI-X checks |
| |
On Fri, Nov 11, 2022 at 02:55:07PM +0100, Thomas Gleixner wrote: > There is no point in doing the same sanity checks over and over in a loop > during MSI-X enablement. Put them in front of the loop and return early > when they fail. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > drivers/pci/msi/msi.c | 67 +++++++++++++++++++++++++------------------------- > 1 file changed, 34 insertions(+), 33 deletions(-)
> + /* PCI_IRQ_VIRTUAL is a horrible hack! */
New comment too :)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
| |