Messages in this thread | | | Date | Thu, 17 Nov 2022 06:00:11 -0800 | From | Ashok Raj <> | Subject | Re: [patch 01/39] PCI/MSI: Check for MSI enabled in __pci_msix_enable() |
| |
On Thu, Nov 17, 2022 at 02:07:33PM +0100, Thomas Gleixner wrote: > On Wed, Nov 16 2022 at 07:39, Ashok Raj wrote: > > On Fri, Nov 11, 2022 at 02:54:15PM +0100, Thomas Gleixner wrote: > > > > Can the pre-enabled checks for msi and msix be moved up before any vector > > range check? > > > > not that it matters for how it fails, does EBUSY sound better? > > Does any caller care about the error code or about the ordering in which > the caller stupity is detected?
No, I don't think so. That's why I prefixed it with "not that it matters" :-)
Just thought it would be good hygiene, but doesn't change anything functionally.
| |