Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch 13/39] PCI/MSI: Use msi_domain_info::bus_token | Date | Wed, 16 Nov 2022 23:51:54 +0100 |
| |
On Wed, Nov 16 2022 at 13:51, Jason Gunthorpe wrote: > On Fri, Nov 11, 2022 at 02:54:35PM +0100, Thomas Gleixner wrote: >> /* PCI-MSI is oneshot-safe */ >> info->chip->flags |= IRQCHIP_ONESHOT_SAFE; >> + /* Let the core update the bus token */ >> + info->bus_token = DOMAIN_BUS_PCI_MSI; > > comment seems a bit obvious
:)
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> > > Should the callers be updated to set this in their "struct > msi_domain_info" ?
For PCI/MSI we can handle that in the core for all of them. :)
The other msi_domain_info usage in various places needs obviously special care.
Thanks,
tglx
| |