Messages in this thread | | | From | Thomas Gleixner <> | Subject | Re: [patch 32/39] PCI/MSI: Reorder functions in msi.c | Date | Wed, 16 Nov 2022 18:10:18 +0100 |
| |
On Wed, Nov 16 2022 at 10:28, Bjorn Helgaas wrote:
> On Fri, Nov 11, 2022 at 02:55:06PM +0100, Thomas Gleixner wrote: >> From: Ahmed S. Darwish <darwi@linutronix.de> >> >> There is no way to navigate msi.c without banging the head against the wall >> every now and then because MSI and MSI-X specific functions are >> intermingled and the code flow is completely non-obvious. >> >> Reorder everthing so common helpers, MSI and MSI-X specific functions are >> grouped together. > > s/everthing/everything/ > >> Suggested-by: Thomas Gleixner <tglx@linutronix.de> >> Signed-off-by: Ahmed S. Darwish <darwi@linutronix.de> >> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > > Acked-by: Bjorn Helgaas <bhelgaas@google.com> > > I assume this is pure code movement, so I didn't even look at the > text below.
It is.
| |