Messages in this thread | | | Date | Wed, 16 Nov 2022 13:53:54 -0400 | From | Jason Gunthorpe <> | Subject | Re: [patch 15/39] PCI/MSI: Get rid of PCI_MSI_IRQ_DOMAIN |
| |
On Fri, Nov 11, 2022 at 02:54:38PM +0100, Thomas Gleixner wrote: > What a zoo: > > PCI_MSI > select GENERIC_MSI_IRQ > > PCI_MSI_IRQ_DOMAIN > def_bool y > depends on PCI_MSI > select GENERIC_MSI_IRQ_DOMAIN > > Ergo PCI_MSI enables PCI_MSI_IRQ_DOMAIN which in turn selects > GENERIC_MSI_IRQ_DOMAIN. So all the dependencies on PCI_MSI_IRQ_DOMAIN are > just an indirection to PCI_MSI. > > Match the reality and just admit that PCI_MSI requires > GENERIC_MSI_IRQ_DOMAIN. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/um/drivers/Kconfig | 1 > arch/um/include/asm/pci.h | 2 - > arch/x86/Kconfig | 1 > arch/x86/include/asm/pci.h | 4 +- > drivers/pci/Kconfig | 8 +---- > drivers/pci/controller/Kconfig | 30 +++++++++----------- > drivers/pci/controller/dwc/Kconfig | 48 ++++++++++++++++---------------- > drivers/pci/controller/mobiveil/Kconfig | 6 ++-- > drivers/pci/msi/Makefile | 2 - > drivers/pci/probe.c | 2 - > include/linux/msi.h | 32 ++++++--------------- > 11 files changed, 56 insertions(+), 80 deletions(-)
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
| |