lkml.org 
[lkml]   [2021]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update_tree()
On Tue, Aug 10, 2021 at 09:06:52PM +0100, David Howells wrote:
> Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
>
> > By using the node id in mem_cgroup_update_tree(), we can delete
> > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo(). Saves 42
> > bytes of kernel text on my config.
> >
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> > Acked-by: Michal Hocko <mhocko@suse.com>
> > Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> > Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> Reviewed-by: David Howells <dhowells@redhat.com>
>
> Though I wonder if:
>
> > - mz = mem_cgroup_page_nodeinfo(memcg, page);
> > + mz = memcg->nodeinfo[nid];
>
> should still have some sort of wrapper function.

I was asked to remove the wrapper function as it didn't provide enough
utility to warrant the indirection.

\
 
 \ /
  Last update: 2021-08-13 20:59    [W:1.033 / U:0.328 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site