lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v14 014/138] mm/filemap: Add folio_next_index()
    On Thu, Jul 15, 2021 at 04:35:00AM +0100, Matthew Wilcox (Oracle) wrote:
    > This helper returns the page index of the next folio in the file (ie
    > the end of this folio, plus one).
    >
    > No changes to generated code.
    >
    > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    > Reviewed-by: Christoph Hellwig <hch@lst.de>
    > Acked-by: Jeff Layton <jlayton@kernel.org>
    > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    > Acked-by: Vlastimil Babka <vbabka@suse.cz>
    > Reviewed-by: William Kucharski <william.kucharski@oracle.com>
    > Reviewed-by: David Howells <dhowells@redhat.com>
    > ---
    > include/linux/pagemap.h | 11 +++++++++++
    > 1 file changed, 11 insertions(+)

    Acked-by: Mike Rapoport <rppt@linux.ibm.com>

    > diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
    > index f7c165b5991f..bd0e7e91bfd4 100644
    > --- a/include/linux/pagemap.h
    > +++ b/include/linux/pagemap.h
    > @@ -406,6 +406,17 @@ static inline pgoff_t folio_index(struct folio *folio)
    > return folio->index;
    > }
    >
    > +/**
    > + * folio_next_index - Get the index of the next folio.
    > + * @folio: The current folio.
    > + *
    > + * Return: The index of the folio which follows this folio in the file.
    > + */

    Maybe note that index is in units of pages?

    > +static inline pgoff_t folio_next_index(struct folio *folio)
    > +{
    > + return folio->index + folio_nr_pages(folio);
    > +}
    > +
    > /**
    > * folio_file_page - The page for a particular index.
    > * @folio: The folio which contains this index.
    > --
    > 2.30.2
    >
    >

    --
    Sincerely yours,
    Mike.

    \
     
     \ /
      Last update: 2021-07-20 12:46    [W:4.074 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site