Messages in this thread | | | Date | Sat, 14 Aug 2021 05:05:44 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v14 050/138] mm/workingset: Convert workingset_activation to take a folio |
| |
On Wed, Jul 21, 2021 at 12:51:57PM +0300, Mike Rapoport wrote: > > /* > > - * page_memcg_rcu - locklessly get the memory cgroup associated with a page > > - * @page: a pointer to the page struct > > + * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio. > > + * @folio: Pointer to the folio. > > * > > - * Returns a pointer to the memory cgroup associated with the page, > > - * or NULL. This function assumes that the page is known to have a > > + * Returns a pointer to the memory cgroup associated with the folio, > > + * or NULL. This function assumes that the folio is known to have a > > * proper memory cgroup pointer. It's not safe to call this function > > - * against some type of pages, e.g. slab pages or ex-slab pages. > > + * against some type of folios, e.g. slab folios or ex-slab folios. > > Maybe > > - * Returns a pointer to the memory cgroup associated with the page, > - * or NULL. This function assumes that the page is known to have a > + * This function assumes that the folio is known to have a > * proper memory cgroup pointer. It's not safe to call this function > - * against some type of pages, e.g. slab pages or ex-slab pages. > + * against some type of folios, e.g. slab folios or ex-slab folios. > + * > + * Return: a pointer to the memory cgroup associated with the folio, > + * or NULL.
I substantially included this change a few days ago and forgot to reply to this email; sorry. It now reads:
/** * folio_memcg_rcu - Locklessly get the memory cgroup associated with a folio. * @folio: Pointer to the folio. * * This function assumes that the folio is known to have a * proper memory cgroup pointer. It's not safe to call this function * against some type of folios, e.g. slab folios or ex-slab folios. * * Return: A pointer to the memory cgroup associated with the folio, * or NULL. */
| |