| From | David Howells <> | Subject | Re: [PATCH v14 025/138] mm/writeback: Add folio_wait_writeback() | Date | Tue, 10 Aug 2021 16:37:08 +0100 |
| |
Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> wait_on_page_writeback_killable() only has one caller, so convert it to > call folio_wait_writeback_killable(). For the wait_on_page_writeback() > callers, add a compatibility wrapper around folio_wait_writeback(). > > Turning PageWriteback() into folio_test_writeback() eliminates a call > to compound_head() which saves 8 bytes and 15 bytes in the two > functions. Unfortunately, that is more than offset by adding the > wait_on_page_writeback compatibility wrapper for a net increase in text > of 7 bytes. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Jeff Layton <jlayton@kernel.org> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Acked-by: Vlastimil Babka <vbabka@suse.cz> > Reviewed-by: William Kucharski <william.kucharski@oracle.com>
Reviewed-by: David Howells <dhowells@redhat.com>
|