| From | David Howells <> | Subject | Re: [PATCH v14 001/138] mm: Convert get_page_unless_zero() to return bool | Date | Tue, 10 Aug 2021 16:26:49 +0100 |
| |
Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> atomic_add_unless() returns bool, so remove the widening casts to int > in page_ref_add_unless() and get_page_unless_zero(). This causes gcc > to produce slightly larger code in isolate_migratepages_block(), but > it's not clear that it's worse code. Net +19 bytes of text. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: David Howells <dhowells@redhat.com>
|