lkml.org 
[lkml]   [2021]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v14 011/138] mm/lru: Add folio LRU functions
    From
    Date
    On 7/15/21 5:34 AM, Matthew Wilcox (Oracle) wrote:
    > Handle arbitrary-order folios being added to the LRU. By definition,
    > all pages being added to the LRU were already head or base pages, but
    > call page_folio() on them anyway to get the type right and avoid the
    > buried calls to compound_head().
    >
    > Saves 783 bytes of kernel text; no functions grow.
    >
    > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
    > Reviewed-by: Yu Zhao <yuzhao@google.com>
    > Reviewed-by: Christoph Hellwig <hch@lst.de>
    > Reviewed-by: David Howells <dhowells@redhat.com>
    > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

    Acked-by: Vlastimil Babka <vbabka@suse.cz>

    Actually looking at the git version, which has also this:

    static __always_inline void update_lru_size(struct lruvec *lruvec,
    enum lru_list lru, enum zone_type zid,
    - int nr_pages)
    + long nr_pages)
    {

    Why now and here? Some of the functions called from update_lru_size()
    still take int so this looks arbitrary?

    \
     
     \ /
      Last update: 2021-08-10 18:03    [W:4.019 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site