Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH v14 085/138] mm/filemap: Add filemap_alloc_folio | Date | Tue, 10 Aug 2021 22:54:38 +0100 |
| |
Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> Reimplement __page_cache_alloc as a wrapper around filemap_alloc_folio > to allow filesystems to be converted at our leisure. Increases > kernel text size by 133 bytes, mostly in cachefiles_read_backing_file(). > pagecache_get_page() shrinks by 32 bytes, though. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Reviewed-by: Christoph Hellwig <hch@lst.de> > ... > +static inline struct page *__page_cache_alloc(gfp_t gfp) > +{ > + return &filemap_alloc_folio(gfp, 0)->page; > +}
Might be worth a note that this *will* return NULL if the allocation fails, though I guess it's deprecated?
Reviewed-by: David Howells <dhowells@redhat.com>
| |