| Date | Tue, 20 Jul 2021 13:41:20 +0300 | From | Mike Rapoport <> | Subject | Re: [PATCH v14 007/138] mm: Add folio_put() |
| |
On Thu, Jul 15, 2021 at 04:34:53AM +0100, Matthew Wilcox (Oracle) wrote: > If we know we have a folio, we can call folio_put() instead of put_page() > and save the overhead of calling compound_head(). Also skips the > devmap checks. > > This commit looks like it should be a no-op, but actually saves 684 bytes > of text with the distro-derived config that I'm testing. Some functions > grow a little while others shrink. I presume the compiler is making > different inlining decisions. > > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org> > Reviewed-by: Zi Yan <ziy@nvidia.com> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Acked-by: Jeff Layton <jlayton@kernel.org> > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > Acked-by: Vlastimil Babka <vbabka@suse.cz> > Reviewed-by: William Kucharski <william.kucharski@oracle.com> > Reviewed-by: David Howells <dhowells@redhat.com> > --- > include/linux/mm.h | 33 ++++++++++++++++++++++++++++----- > 1 file changed, 28 insertions(+), 5 deletions(-)
Acked-by: Mike Rapoport <rppt@linux.ibm.com>
|