| Date | Fri, 15 May 2020 15:38:24 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 07/19] spi: dw: Discard unused void priv pointer |
| |
On Fri, May 15, 2020 at 01:47:46PM +0300, Serge Semin wrote: > Seeing the "void *priv" member of the dw_spi data structure is unused > let's remove it. The glue-layers can embed the DW APB SSI controller > descriptor into their private data object. MMIO driver for instance > already utilizes that design pattern.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > Cc: Georgy Vlasov <Georgy.Vlasov@baikalelectronics.ru> > Cc: Ramil Zaripov <Ramil.Zaripov@baikalelectronics.ru> > Cc: Alexey Malahov <Alexey.Malahov@baikalelectronics.ru> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> > Cc: Paul Burton <paulburton@kernel.org> > Cc: Ralf Baechle <ralf@linux-mips.org> > Cc: Allison Randal <allison@lohutok.net> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Gareth Williams <gareth.williams.jx@renesas.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: linux-mips@vger.kernel.org > Cc: devicetree@vger.kernel.org > > --- > > Changelog v2: > - It's a new patch created as a result of more thorough driver study. > --- > drivers/spi/spi-dw.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h > index 60e9e430ce7b..b6ab81e0c747 100644 > --- a/drivers/spi/spi-dw.h > +++ b/drivers/spi/spi-dw.h > @@ -147,8 +147,6 @@ struct dw_spi { > dma_addr_t dma_addr; /* phy address of the Data register */ > const struct dw_spi_dma_ops *dma_ops; > > - /* Bus interface info */ > - void *priv; > #ifdef CONFIG_DEBUG_FS > struct dentry *debugfs; > #endif > -- > 2.25.1 >
-- With Best Regards, Andy Shevchenko
|