| Date | Fri, 8 May 2020 22:21:44 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH 13/17] spi: dw: Initialize paddr in DW SPI MMIO private data |
| |
On Fri, May 08, 2020 at 04:29:38PM +0300, Serge Semin wrote: > This field is used only for the DW SPI DMA code initialization, that's > why there were no problems with it being uninitialized in Dw SPI MMIO > driver. Since in a further patch we are going to introduce the DW SPI DMA > support in the MMIO version of the driver, lets set the field with the > physical address of the DW SPI controller registers region.
...
> - dws->regs = devm_platform_ioremap_resource(pdev, 0); > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + dws->regs = devm_ioremap_resource(&pdev->dev, mem);
There is a helper dws->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &mem);
> if (IS_ERR(dws->regs)) { > dev_err(&pdev->dev, "SPI region map failed\n"); > return PTR_ERR(dws->regs); > } > + dws->paddr = mem->start; > > dws->irq = platform_get_irq(pdev, 0); > if (dws->irq < 0) > -- > 2.25.1 >
-- With Best Regards, Andy Shevchenko
|