| From | "Kirill A. Shutemov" <> | Subject | Re: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages | Date | Tue, 25 Jun 2013 17:56:55 +0300 (EEST) |
| |
Dave Hansen wrote: > On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > > +static inline unsigned long mapping_align_mask(struct address_space *mapping) > > +{ > > + if (mapping_can_have_hugepages(mapping)) > > + return PAGE_MASK & ~HPAGE_MASK; > > + return get_align_mask(); > > +} > > get_align_mask() appears to be a bit more complicated to me than just a > plain old mask. Are you sure you don't need to pick up any of its > behavior for the mapping_can_have_hugepages() case?
get_align_mask() never returns more strict mask then we do in mapping_can_have_hugepages() case.
I can modify it this way:
unsigned long mask = get_align_mask();
if (mapping_can_have_hugepages(mapping)) mask &= PAGE_MASK & ~HPAGE_MASK; return mask;
But it looks more confusing for me. What do you think?
-- Kirill A. Shutemov
|