| Date | Tue, 21 May 2013 12:04:54 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 05/39] memcg, thp: charge huge cache pages |
| |
On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > mem_cgroup_cache_charge() has check for PageCompound(). The check > prevents charging huge cache pages. > > I don't see a reason why the check is present. Looks like it's just > legacy (introduced in 52d4b9a memcg: allocate all page_cgroup at boot).
FWIW, that commit introduced two PageCompound() checks. The other one went away inexplicably in 01b1ae63c22.
Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
|