Messages in this thread | | | Date | Wed, 22 May 2013 07:56:59 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 29/39] thp: move maybe_pmd_mkwrite() out of mk_huge_pmd() |
| |
On 05/22/2013 07:37 AM, Kirill A. Shutemov wrote: > Dave Hansen wrote: >> On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: >>> From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> >>> >>> It's confusing that mk_huge_pmd() has sematics different from mk_pte() >>> or mk_pmd(). >>> >>> Let's move maybe_pmd_mkwrite() out of mk_huge_pmd() and adjust >>> prototype to match mk_pte(). >> >> Was there a motivation to do this beyond adding consistency? Do you use >> this later or something? > > I spent some time on debugging problem caused by this inconsistency, so at > that point I was motivated to fix it. :)
A little anecdote that this bit you in practice to help indicate this isn't just random code churn would be nice.
| |