lkml.org 
[lkml]   [2013]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCHv4 33/39] thp, mm: implement do_huge_linear_fault()
From
On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov
<kirill.shutemov@linux.intel.com> wrote:
> page = vmf.page;
> +
> + /*
> + * If we asked for huge page we expect to get it or VM_FAULT_FALLBACK.
> + * If we don't ask for huge page it must be splitted in ->fault().
> + */
> + BUG_ON(PageTransHuge(page) != thp);
> +
Based on the log message in 34/39(
If the area of page cache required to create huge is empty, we create a
new huge page and return it.), the above trap looks bogus.

if (thp)
BUG_ON(!PageTransHuge(page));


\
 
 \ /
  Last update: 2013-05-22 16:01    [W:0.939 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site