lkml.org 
[lkml]   [2013]   [May]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCHv4 37/39] thp: handle write-protect exception to file-backed huge pages
Date
Hillf Danton wrote:
> On Sun, May 12, 2013 at 9:23 AM, Kirill A. Shutemov
> <kirill.shutemov@linux.intel.com> wrote:
> > @@ -1120,7 +1119,7 @@ int do_huge_pmd_wp_page(struct mm_struct *mm, struct vm_area_struct *vma,
> >
> > page = pmd_page(orig_pmd);
> > VM_BUG_ON(!PageCompound(page) || !PageHead(page));
> > - if (page_mapcount(page) == 1) {
> > + if (PageAnon(page) && page_mapcount(page) == 1) {
>
> Could we avoid copying huge page if
> no-one else is using it, no matter anon?

No. The page is still in page cache and can be later accessed later.
We could isolate the page from page cache, but I'm not sure whether it's
good idea.

do_wp_page() does exectly the same for small pages, so let's keep it
consistent.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-05-23 14:42    [W:0.125 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site