| Date | Tue, 21 May 2013 16:57:23 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 32/39] mm: cleanup __do_fault() implementation |
| |
On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > Let's cleanup __do_fault() to prepare it for transparent huge pages > support injection. > > Cleanups: > - int -> bool where appropriate; > - unindent some code by reverting 'if' condition; > - extract !pte_same() path to get it clear; > - separate pte update from mm stats update; > - some comments reformated;
I've scanned through the rest of these patches. They look OK, and I don't have _too_ much to say. They definitely need some closer review, but I think you should concentrate your attention on the stuff _before_ this point in the series.
|