Messages in this thread | | | Date | Tue, 21 May 2013 15:56:41 -0700 | From | Dave Hansen <> | Subject | Re: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages |
| |
On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote: > +static inline unsigned long mapping_align_mask(struct address_space *mapping) > +{ > + if (mapping_can_have_hugepages(mapping)) > + return PAGE_MASK & ~HPAGE_MASK; > + return get_align_mask(); > +}
get_align_mask() appears to be a bit more complicated to me than just a plain old mask. Are you sure you don't need to pick up any of its behavior for the mapping_can_have_hugepages() case?
| |