lkml.org 
[lkml]   [2013]   [May]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCHv4 27/39] x86-64, mm: proper alignment mappings with hugepages
    On 05/11/2013 06:23 PM, Kirill A. Shutemov wrote:
    > +static inline unsigned long mapping_align_mask(struct address_space *mapping)
    > +{
    > + if (mapping_can_have_hugepages(mapping))
    > + return PAGE_MASK & ~HPAGE_MASK;
    > + return get_align_mask();
    > +}

    get_align_mask() appears to be a bit more complicated to me than just a
    plain old mask. Are you sure you don't need to pick up any of its
    behavior for the mapping_can_have_hugepages() case?


    \
     
     \ /
      Last update: 2013-05-22 02:01    [W:2.898 / U:0.260 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site