| From | "Kirill A. Shutemov" <> | Subject | [PATCHv4 05/39] memcg, thp: charge huge cache pages | Date | Sun, 12 May 2013 04:23:02 +0300 |
| |
From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
mem_cgroup_cache_charge() has check for PageCompound(). The check prevents charging huge cache pages.
I don't see a reason why the check is present. Looks like it's just legacy (introduced in 52d4b9a memcg: allocate all page_cgroup at boot).
Let's just drop it.
Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: Michal Hocko <mhocko@suse.cz> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> --- mm/memcontrol.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index fe4f123..a7de6a7 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4080,8 +4080,6 @@ int mem_cgroup_cache_charge(struct page *page, struct mm_struct *mm, if (mem_cgroup_disabled()) return 0; - if (PageCompound(page)) - return 0; if (!PageSwapCache(page)) ret = mem_cgroup_charge_common(page, mm, gfp_mask, type); -- 1.7.10.4
|