| Date | Mon, 22 Apr 2013 15:22:18 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 16/32] dmaengine: ste_dma40: Remove unnecessary call to d40_phy_cfg() |
| |
On Thu, Apr 18, 2013 at 11:11:58AM +0100, Lee Jones wrote: > All configuration left in d40_phy_cfg() is runtime configurable and > there is already a call into it from d40_runtime_config(), so let's > rely on that. > > Cc: Vinod Koul <vinod.koul@intel.com> > Cc: Dan Williams <djbw@fb.com> > Cc: Per Forlin <per.forlin@stericsson.com> > Cc: Rabin Vincent <rabin@rab.in> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Acked-by: Vinod Koul <vinod.koul@intel.com>
-- ~Vinod > --- > drivers/dma/ste_dma40.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c > index 178a03c..1c570b6 100644 > --- a/drivers/dma/ste_dma40.c > +++ b/drivers/dma/ste_dma40.c > @@ -2437,9 +2437,6 @@ static int d40_alloc_chan_resources(struct dma_chan *chan) > } > > pm_runtime_get_sync(d40c->base->dev); > - /* Fill in basic CFG register values */ > - d40_phy_cfg(&d40c->dma_cfg, &d40c->src_def_cfg, > - &d40c->dst_def_cfg, chan_is_logical(d40c)); > > d40_set_prio_realtime(d40c); > > -- > 1.7.10.4 >
|