lkml.org 
[lkml]   [2013]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 17/32] dmaengine: ste_dma40: Remove redundant argument from d40_phy_cfg()
    From
    On Thu, Apr 18, 2013 at 12:11 PM, Lee Jones <lee.jones@linaro.org> wrote:

    > d40_phy_cfg is now only ever called to configure physical channels, so
    > there's no requirement to pass though an argument describing the type
    > of channel and to subsequently test for it.
    >
    > Cc: Vinod Koul <vinod.koul@intel.com>
    > Cc: Dan Williams <djbw@fb.com>
    > Cc: Per Forlin <per.forlin@stericsson.com>
    > Cc: Rabin Vincent <rabin@rab.in>
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    As mentioned, squash this into the patch where this is made redundant,
    no point in first making an argument unused in one patch and then
    deleting it in another patch.

    Yours,
    Linus Walleij


    \
     
     \ /
      Last update: 2013-04-25 14:01    [W:5.977 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site