lkml.org 
[lkml]   [2013]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/32] dmaengine: ste_dma40: Also report the number of logical channels
On Mon, Apr 22, 2013 at 11:37:15AM +0100, Lee Jones wrote:
> On Mon, 22 Apr 2013, Vinod Koul wrote:
> You only get a warning for this too:
Yup, oh i wrongly mention error
>
> WARNING: quoted string split across lines
> #33: FILE: drivers/dma/ste_dma40.c:3204:
> + dev_info(&pdev->dev, "hardware revision: %d @ 0x%x with "
> + "%d physical channels and %d logical channels\n",
>
> > > How would you solve this?
> > Use common sense :) I would never sacrfice readablity of code. Erring on 80chars
> > is fine by me as long as it makes sense.
>
> Common sense to me says split a string which goes over 100 chars. :)
agreed :)
>
> ... and I don't think readability is compromised all that much, if at all.
I think if you start above at next line, you can be in 100chars and still be in
single line...
dev_info(&pdev->dev,
"hardware revision: %d @ 0x%x with %d physical channels and %d logical channels\n",
Plus a truncated one would help too...
s/revision/rev
s/channels/ch
etc

would bring this to saner levels :)

--
~Vinod


\
 
 \ /
  Last update: 2013-04-22 13:41    [W:0.352 / U:1.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site