Messages in this thread | | | Date | Mon, 22 Apr 2013 11:18:33 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 17/32] dmaengine: ste_dma40: Remove redundant argument from d40_phy_cfg() |
| |
> > + if ((cfg->dir == STEDMA40_PERIPH_TO_MEM) || > > + (cfg->dir == STEDMA40_PERIPH_TO_PERIPH)) { > Why would you need your own direction defines, I see that there is not much > diff between these and what dmaengine defines, so perhpas you could use > those?
I agree. I'll speak to the STE folk.
For this (and other) patch(es), I'll continue to use the STEDMA40 ones though. Converting everything over to the generic defines should be a subsequent patch-set IMHO.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |