lkml.org 
[lkml]   [2013]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 22/32] dmaengine: ste_dma40: Allocate plat_data on declaration
On Thu, Apr 18, 2013 at 11:12:04AM +0100, Lee Jones wrote:
> It's the way that most other drivers do it.
>
> Very trivial clean-up which reduces line count and simplifies code.
>
> Cc: Vinod Koul <vinod.koul@intel.com>
> Cc: Dan Williams <djbw@fb.com>
> Cc: Per Forlin <per.forlin@stericsson.com>
> Cc: Rabin Vincent <rabin@rab.in>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: Vinod Koul <vnod.koul@intel.com>

--
~Vinod
> ---
> drivers/dma/ste_dma40.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
> index 805049c..6f9f801 100644
> --- a/drivers/dma/ste_dma40.c
> +++ b/drivers/dma/ste_dma40.c
> @@ -3119,7 +3119,7 @@ static int __init d40_phy_res_init(struct d40_base *base)
>
> static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
> {
> - struct stedma40_platform_data *plat_data;
> + struct stedma40_platform_data *plat_data = pdev->dev.platform_data;
> struct clk *clk = NULL;
> void __iomem *virtbase = NULL;
> struct resource *res = NULL;
> @@ -3190,8 +3190,6 @@ static struct d40_base * __init d40_hw_detect_init(struct platform_device *pdev)
> goto failure;
> }
>
> - plat_data = pdev->dev.platform_data;
> -
> /* The number of physical channels on this HW */
> if (plat_data->num_of_phy_chans)
> num_phy_chans = plat_data->num_of_phy_chans;
> --
> 1.7.10.4
>


\
 
 \ /
  Last update: 2013-04-22 12:41    [W:0.673 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site