Messages in this thread | | | Date | Mon, 22 Apr 2013 15:49:49 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 05/32] dmaengine: ste_dma40: Supply macros to resolve 'src' and 'dst' directions |
| |
On Mon, Apr 22, 2013 at 11:27:48AM +0100, Lee Jones wrote: > On Mon, 22 Apr 2013, Vinod Koul wrote: > > > On Thu, Apr 18, 2013 at 11:11:47AM +0100, Lee Jones wrote: > > > There are lots of lengthy if() statements located sporadically up and > > > down the driver. This simple macro should make many of them a little > > > simpler to decipher. The remainder have to stay in place, as they > > > detail slightly more specific settings. > > I would like these to be DMAENGINE_IS_SRC... > > I don't understand, as they're DMA40 specific? > > > and this patch use the defines provided in dmaengine > > I think a subsequent patch doing he following would be more suitable: > > s/STEDMA40_MEM_TO_MEM/DMA_MEM_TO_MEM/ > s/STEDMA40_MEM_TO_PERIPH/DMA_MEM_TO_DEV/ > s/STEDMA40_PERIPH_TO_MEM/DMA_DEV_TO_MEM/ > s/STEDMA40_PERIPH_TO_PERIPH/DMA_DEV_TO_DEV/ > > If you don't mind? sounds like a good plan
-- ~Vinod
| |