| Date | Mon, 14 Feb 2022 11:06:07 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit address |
| |
On Thu, Jan 27, 2022 at 08:40:59PM +0000, Yazen Ghannam wrote: > Move the DRAM limit check into a separate helper function.
You're still writing the "what" in commit messages - pls make a note to write about "why" you're doing a change instead.
Because I don't see why you're doing this. Because umc_normaddr_to_sysaddr() is supposed to call helper functions only?
Now if you had the "why" I wouldn't be wondering...
:)
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|