Messages in this thread | | | Date | Wed, 9 Mar 2022 22:03:26 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v4 08/24] EDAC/amd64: Define function to check DRAM limit address |
| |
On Mon, Feb 14, 2022 at 11:06:07AM +0100, Borislav Petkov wrote: > On Thu, Jan 27, 2022 at 08:40:59PM +0000, Yazen Ghannam wrote: > > Move the DRAM limit check into a separate helper function. > > You're still writing the "what" in commit messages - pls make a note to > write about "why" you're doing a change instead. > > Because I don't see why you're doing this. Because > umc_normaddr_to_sysaddr() is supposed to call helper functions only? > > Now if you had the "why" I wouldn't be wondering... > > :) >
Yes, you're right. I'll update this.
Yes, the goal is to break up the translation procedure into discrete high-level steps.
Thanks, Yazen
| |