Messages in this thread | | | Date | Wed, 9 Mar 2022 22:32:52 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v4 21/24] EDAC/amd64: Update CS ID calculation to match reference code |
| |
On Mon, Feb 14, 2022 at 02:42:36PM +0100, Borislav Petkov wrote: > On Thu, Jan 27, 2022 at 08:41:12PM +0000, Yazen Ghannam wrote: > > Redo the current CS ID calculations to match the reference code. Helper > > functions are introduced that will be expanded for future DF versions. > > "Describe your changes in imperative mood, e.g. "make xyzzy do frotz" > instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy > to do frotz", as if you are giving orders to the codebase to change > its behaviour." > > Also, do not talk about what your patch does - that should hopefully be > visible in the diff itself. Rather, talk about *why* you're doing what > you're doing. > > Just a reminder. >
Yep, thank you. I'll update this.
Thanks, Yazen
| |