| Date | Mon, 14 Feb 2022 14:09:07 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 18/24] EDAC/amd64: Define function to insert CS ID into address |
| |
On Thu, Jan 27, 2022 at 08:41:09PM +0000, Yazen Ghannam wrote: > @@ -1326,20 +1331,7 @@ static int denormalize_addr(struct addr_ctx *ctx) > return -EINVAL; > } > > - if (num_intlv_bits > 0) { > - u64 temp_addr_i; > - > - /* > - * The pre-interleaved address consists of XXXXXXIIIYYYYY > - * where III is the ID for this CS, and XXXXXXYYYYY are the > - * address bits from the post-interleaved address. > - * "num_intlv_bits" has been calculated to tell us how many "I" > - * bits there are. "intlv_addr_bit" tells us how many "Y" bits > - * there are (where "I" starts). > - */
That comment looks useful, why remove it?
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
|