lkml.org 
[lkml]   [2022]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v4 02/24] EDAC/amd64: Define functions for DramOffset
On Thu, Jan 27, 2022 at 08:40:53PM +0000, Yazen Ghannam wrote:
> @@ -1099,22 +1140,13 @@ static int umc_normaddr_to_sysaddr(u64 norm_addr, u16 nid, u8 umc, u64 *sys_addr
> ctx.nid = nid;
> ctx.inst_id = umc;
>
> - /* Read D18F0x1B4 (DramOffset), check if base 1 is used. */
> - if (df_indirect_read_instance(nid, 0, 0x1B4, umc, &ctx.tmp))
> + if (remove_dram_offset(&ctx)) {
> + pr_debug("Failed to remove DRAM offset");

You don't need that pr_debug - remove_dram_offset() already has one for
the single error case.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2022-02-11 20:24    [W:0.337 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site