Messages in this thread | | | Date | Wed, 9 Mar 2022 22:31:32 +0000 | From | Yazen Ghannam <> | Subject | Re: [PATCH v4 18/24] EDAC/amd64: Define function to insert CS ID into address |
| |
On Mon, Feb 14, 2022 at 02:09:07PM +0100, Borislav Petkov wrote: > On Thu, Jan 27, 2022 at 08:41:09PM +0000, Yazen Ghannam wrote: > > @@ -1326,20 +1331,7 @@ static int denormalize_addr(struct addr_ctx *ctx) > > return -EINVAL; > > } > > > > - if (num_intlv_bits > 0) { > > - u64 temp_addr_i; > > - > > - /* > > - * The pre-interleaved address consists of XXXXXXIIIYYYYY > > - * where III is the ID for this CS, and XXXXXXYYYYY are the > > - * address bits from the post-interleaved address. > > - * "num_intlv_bits" has been calculated to tell us how many "I" > > - * bits there are. "intlv_addr_bit" tells us how many "Y" bits > > - * there are (where "I" starts). > > - */ > > That comment looks useful, why remove it? >
No firm reason. I just got the feeling it wasn't very useful. But I'll keep it in case others find it helpful.
Thanks, Yazen
| |