Messages in this thread | | | Date | Thu, 10 Mar 2022 17:09:19 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave Address Bit |
| |
On Wed, Mar 09, 2022 at 10:12:00PM +0000, Yazen Ghannam wrote: > Similar goal as in other places. When the function seems sufficiently long > (subjective I know), break it up into helper functions. > > I've been trying to decide based on logical steps. Do you have any general > recommendations or rule-of-thumb?
Documentation/process/coding-style.rst, 6) Functions has some good ideas about it. To me, a function should do one thing and one thing only but yes, the decision is subjective.
-- Regards/Gruss, Boris.
https://people.kernel.org/tglx/notes-about-netiquette
| |