lkml.org 
[lkml]   [2022]   [Mar]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 10/24] EDAC/amd64: Define function to get Interleave Address Bit
On Wed, Mar 09, 2022 at 10:12:00PM +0000, Yazen Ghannam wrote:
> Similar goal as in other places. When the function seems sufficiently long
> (subjective I know), break it up into helper functions.
>
> I've been trying to decide based on logical steps. Do you have any general
> recommendations or rule-of-thumb?

Documentation/process/coding-style.rst, 6) Functions has some good ideas
about it. To me, a function should do one thing and one thing only but
yes, the decision is subjective.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2022-03-10 17:11    [W:0.063 / U:0.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site