| From | Geert Uytterhoeven <> | Date | Tue, 28 Dec 2021 11:32:42 +0100 | Subject | Re: [RFC 12/32] iio: adc: Kconfig: add HAS_IOPORT dependencies |
| |
Hi Niklas,
On Mon, Dec 27, 2021 at 5:53 PM Niklas Schnelle <schnelle@linux.ibm.com> wrote: > In a future patch HAS_IOPORT=n will result in inb()/outb() and friends > not being declared. We thus need to add HAS_IOPORT as dependency for > those drivers using them. > > Co-developed-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Arnd Bergmann <arnd@kernel.org> > Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Thanks for your patch!
> --- a/drivers/iio/adc/Kconfig > +++ b/drivers/iio/adc/Kconfig > @@ -119,7 +119,7 @@ config AD7606 > > config AD7606_IFACE_PARALLEL > tristate "Analog Devices AD7606 ADC driver with parallel interface support" > - depends on HAS_IOMEM > + depends on HAS_IOPORT
While this driver uses ins[bw](), this seems unrelated to legacy I/O space, as the driver maps a MMIO region. Probably different accessors should be used instead.
Note that this driver has no in-tree users. Same for the SPI variant, but at least that one has modern json-schema DT bindings ;-)
> select AD7606 > help > Say yes here to build parallel interface support for Analog Devices:
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
|